Skip to content

Move environment-updates defined by configs after composition. #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Move environment-updates defined by configs after composition. #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions earthmover/earthmover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,6 @@ def __init__(self,
# convert state_configs to YamlMapping so we can inject CLI overrides
self.state_configs = YamlMapping().update(self.state_configs)
self.state_configs = self.inject_cli_overrides(self.state_configs, "config.")

# Prepare the output directory for destinations.
self.state_configs['output_dir'] = os.path.expanduser(self.state_configs['output_dir'])

# Set the temporary directory in cases of disk-spillage.
dask.config.set({'temporary_directory': self.state_configs['tmp_dir']})

# Set a directory for installing packages.
self.packages_dir = os.path.join(os.getcwd(), 'packages')
Expand Down Expand Up @@ -167,9 +161,13 @@ def compile(self, to_disk: bool = False):

### Optionally merge packages to update user-configs and write the composed YAML to disk.
self.user_configs = self.merge_packages() or self.user_configs
self.user_configs = self.inject_cli_overrides(self.user_configs)

if to_disk:
self.user_configs.to_disk(self.compiled_yaml_file)
self.user_configs = self.inject_cli_overrides(self.user_configs)

# Expand the output directory before compiling destinations.
self.state_configs['output_dir'] = os.path.expanduser(self.state_configs['output_dir'])

### Compile the nodes and add to the graph type-by-type.
self.sources = self.compile_node_configs(
Expand Down Expand Up @@ -252,12 +250,17 @@ def execute(self, graph: Graph):
Iterate subgraphs in `Earthmover.graph` and execute each Node in order.
:return:
"""
# Create the output directory.
if not os.path.isdir(self.state_configs['output_dir']):
self.logger.info(
f"creating output directory {self.state_configs['output_dir']}"
)
os.makedirs(self.state_configs['output_dir'], exist_ok=True)

# Set the temporary directory in cases of disk-spillage.
dask.config.set({'temporary_directory': self.state_configs['tmp_dir']})

# Execute the graph node-by-node.
for idx, component in enumerate(nx.weakly_connected_components(graph)):
self.logger.debug(f"processing component {idx}")

Expand Down