-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/inLineSource: adding another source type #131
Draft
gnguyen87
wants to merge
15
commits into
main
Choose a base branch
from
feature/inLineSource
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c6721b8
minimal changes required
johncmerfeld 3d24a73
resolve changlelog
johncmerfeld fb77791
bump pandas a bit
johncmerfeld 3272570
add a couple explicit support lines to setup.py
johncmerfeld 58e9dc0
add comment explaining whythe optimizer needs to be turned off
johncmerfeld 66d63e8
make regex pattern a raw string
johncmerfeld 9f73a46
apply performance-enhancing settings
johncmerfeld 067ebd9
add an inLineSource class
gnguyen87 201d211
modify inLineSource class
gnguyen87 573edf9
import inLineSource instance to handle file hasing logic
gnguyen87 da7f22d
Take care of logic to handle different types of inLineSource Orientation
gnguyen87 98d1a66
Cast dict vals to str type to appropriately join row values together
gnguyen87 719975f
Rename orientation
gnguyen87 120d0ef
Remove print statement
gnguyen87 785c71e
Add test cases for inLineSource
gnguyen87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,13 @@ | ||
# September 2024 - for now we need to do this in order to turn off the Dask | ||
# query optimizer - see https://blog.dask.org/2023/08/25/dask-expr-introduction | ||
# For reasons unknown, it doesn't yet work with Earthmover. A future Dask | ||
# version may force us to use the query optimizer, but hopefully by then, | ||
# the bugs that emerge when we use it with Earthmover will have been fixed. | ||
import dask | ||
dask.config.set({'dataframe.query-planning': False}) | ||
|
||
# performance enhancements | ||
dask.config.set({"dataframe.convert-string": True}) | ||
import pandas as pd | ||
pd.options.mode.copy_on_write = True | ||
pd.options.mode.string_storage = "pyarrow" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
{ "family": "reptile", "all_lifespans": [40,6,55,45,30,18,8,15,45], "all_lifespans_quoted": ["40","6","55","45","30","18","8","15","45"] } | ||
{ "family": "invertebrate", "all_lifespans": [0.25,5.0,1.5,20.0,3.0,50.0,0.2,0.5,100.0,1.0], "all_lifespans_quoted": ["0.25","5.0","1.5","20.0","3.0","50.0","0.2","0.5","100.0","1.0"] } | ||
{ "family": "fish", "all_lifespans": [15,8,4,7,5], "all_lifespans_quoted": ["15","8","4","7","5"] } | ||
{ "family": "mammal", "all_lifespans": [14,14,7,40,12,65,4,25,40,45,8,15,12,40,20,22,20,40,18,40,20], "all_lifespans_quoted": ["14","14","7","40","12","65","4","25","40","45","8","15","12","40","20","22","20","40","18","40","20"] } | ||
{ "family": "bird", "all_lifespans": [50,20,30,25,4,9,35,20,23,12,20,30,8,18,12], "all_lifespans_quoted": ["50","20","30","25","4","9","35","20","23","12","20","30","8","18","12"] } | ||
{ "family": "reptile", "all_lifespans": [40,6,55,45,30,18,8,15,45], "all_lifespans_quoted": ["40","6","55","45","30","18","8","15","45"] } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,10 @@ | ||
wheel | ||
aiohttp>=3.8.1 | ||
dask[dataframe]~=2023.5.0 | ||
dask[dataframe]~=2024.8.0; python_version>="3.10" | ||
dask[dataframe]~=2023.5.0; python_version<"3.10" | ||
Jinja2>=2.11.3 | ||
networkx>=2.6.3 | ||
pandas>=1.3.5,<=2.2.1 | ||
pandas[performance]~=2.2.2; python_version>="3.10" | ||
pandas>=1.3.5,<=2.2.1; python_version<"3.10" | ||
requests>=2.23.0 | ||
setuptools>=44.0.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider
InlineSource
to fit convention of other nodes.