Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#291 implement sortByMany #320

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#291 implement sortByMany #320

wants to merge 2 commits into from

Conversation

shafi-
Copy link

@shafi- shafi- commented May 6, 2023

This PR aims to add support for sortByMany method asked in the issue #291
Corresponding Laravel implementation https://github.com/laravel/framework/blob/8.x/src/Illuminate/Collections/Collection.php#L1325

@ecrmnn
Copy link
Owner

ecrmnn commented May 16, 2023

Thanks for the PR, @shafi- 🙏

I see I've made the mistake of thinking this was a public method that should be exposed to the user.

On a closer look, I see that sortByMany is called from the sortBy method, when the user passes an array or closure.
https://github.com/laravel/framework/blob/8.x/src/Illuminate/Collections/Collection.php#L1289

Could you please update you PR to reflect this?

@shafi-
Copy link
Author

shafi- commented May 16, 2023

@ecrmnn, Thanks for your response.

Updated it. Let me know if it is fine or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants