Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide list for filter_by_keys #384

Merged
merged 4 commits into from
Jun 26, 2024
Merged

provide list for filter_by_keys #384

merged 4 commits into from
Jun 26, 2024

Conversation

EddyCMWF
Copy link
Contributor

This allows users to pass of list of values to filter a key by. This is useful when a set of keys can construct a datacube, e.g. models/variables.

Extra note, this makes configuration for netCDF conversion much simpler

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.15%. Comparing base (b098bc5) to head (151037b).

Files Patch % Lines
cfgrib/messages.py 0.00% 3 Missing ⚠️
cfgrib/dataset.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   40.44%   41.15%   +0.70%     
==========================================
  Files          26       26              
  Lines        2141     2170      +29     
  Branches      283      284       +1     
==========================================
+ Hits          866      893      +27     
- Misses       1275     1277       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iainrussell iainrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good addition - thank you!

@EddyCMWF EddyCMWF merged commit 011a5d1 into master Jun 26, 2024
86 checks passed
@EddyCMWF EddyCMWF deleted the filter-by-keys-list branch June 27, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants