Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "edition" from GLOBAL_ATTRIBUTES_KEYS #233

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

b8raoult
Copy link
Contributor

No description provided.

@StephanSiemen
Copy link
Contributor

I see we have an assertion in the unit test "test_Dataset_encode_cf_vertical" for edition number :-( Can have a look later ...

@iainrussell
Copy link
Member

I think it's reasonable to remove this key because it is very specific to GRIB and not relevant to the generated NetCDF / xarray data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants