-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Basic ssh_config support #15499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic ssh_config support #15499
Conversation
Signed-off-by: KnowZero <[email protected]>
packages/remote/src/electron-node/ssh/remote-ssh-connection-provider.ts
Outdated
Show resolved
Hide resolved
packages/remote/src/electron-node/ssh/remote-ssh-connection-provider.ts
Outdated
Show resolved
Hide resolved
Hi, thanks for the contribution. It works great. I left a few suggestions. |
I definitely signed it, same way I signed it before. It's weird/ Clicking it, it seems the sign verification is down? |
I was also under the asumption you did. |
sorry i take that back. There actually seems to be a problem at eclipse right now with the eca validation |
Validation seems to be fixed so I revalidated it |
Signed-off-by: KnowZero <[email protected]>
Signed-off-by: KnowZero <[email protected]>
@jonah-iden Okay, I implemented ssh-config |
Signed-off-by: KnowZero <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a few smaller improvements for the usage of SSH config. Hope that was ok. But this looks good to me now.
What it does
Very basic support for ssh_config files and quick access to ssh_config hosts.
Currently only Host, Hostname, Port, User, and IdentityFile is supported. With Host allowing some wildcards which can be accessed through %h
How to test
Step 1:
Create an sh file with the following and run it, it will generate a ssh_config file and docker files and ssh keys to test with:
Step 2:
set
remote.ssh.configFile
setting to point to config file generatedStep 3:
docker-compuse up
Step 4:
When connecting to remote host, you can either access them via typing like
test1
or pick it in the quick access menu(Connect Current Window to Host in Config File). You can also do things likeroot@test1
, default password ispassword
. You can also test wildcard viaroot@test2_127
,test3_1
shows single character wildcard andtest4
is key login without passwordFollow-ups
Partly fixes #14102 and #14289
@jonah-iden
Breaking changes
Attribution
Review checklist
Reminder for reviewers