Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "Save As" for custom editors #14972

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 18, 2025

What it does

Closes #14966

Allows Saveable instances to implement their own saveAs routine. This is required to fix saving for custom editors. All other editors can continue to just serialize their contents to use the generic "Save As" function.

How to test

Follow the reproduction steps of #14966 and ensure that the "Save As" functionality works for both the .pawDraw and .cscratch files.

Review checklist

Reminder for reviewers

@msujew msujew added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Feb 18, 2025
@msujew msujew force-pushed the msujew/fix-custom-editor-save-as branch from 57df82f to d9a75e2 Compare February 18, 2025 22:29
@VadimGroGit
Copy link

I'm sorry, I'm an absolute noob and I don't know the procedure for including patches in the Theia build.

I was hoping to see

msujew/fix-custom-editor-save-as

in the February build, but as far as I understand, this is not the case.

I did a branch checkout and checked - SaveAs works for both CustomEditors, text and binary.

When can I expect to see this branch included in the main release?

Or are there some problems with fix?

@msujew
Copy link
Member Author

msujew commented Mar 4, 2025

@VadimGroGit Thanks for looking into it. This is a less impactful bug/fix, so it's likely nobody had the opportunity to review it in the meantime. @JonasHelming care to assign someone?

@JonasHelming JonasHelming requested a review from rschnekenbu March 4, 2025 10:44
Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msujew, reading the code and testing, I did not find any issue. I could also reproduce the steps given in references issue. Thanks!

@msujew msujew merged commit 22d001e into master Mar 5, 2025
10 of 11 checks passed
@msujew msujew deleted the msujew/fix-custom-editor-save-as branch March 5, 2025 19:03
@github-actions github-actions bot added this to the 1.60.0 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

VSCode CustomEditor - SaveAs command cannot be executed
3 participants