Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebook widget disposal #14964

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Fix notebook widget disposal #14964

merged 1 commit into from
Feb 19, 2025

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 18, 2025

What it does

In case the notebook loading fails, disposing the notebook widget also failed (due to calling disconnect on undefined), which led to a cascade of other issues related to that widget.

How to test

  1. Open a notebook file (I created a copy of an existing notebook
  2. Close Theia and delete the notebook file
  3. Open Theia again, the notebook error marker should be visible on the widget
  4. Recreate the original notebook file
  5. Close and reopen the widget. It should load the recreated notebook as expected.

Review checklist

Reminder for reviewers

@msujew msujew added the notebook issues related to notebooks label Feb 18, 2025
@msujew msujew requested a review from jonah-iden February 18, 2025 16:59
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@msujew msujew merged commit 3435376 into master Feb 19, 2025
10 of 11 checks passed
@github-actions github-actions bot added this to the 1.59.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants