[#1668] API types to simplify work with launch configuration attributes

[ruspl-afed]

• identify launch attribute
• connect it with preference metadata (to supply defaults/label/description)
• read attribute from configuration
• write attribute to configuration working copy
• demonstrate usage for ExternalTools

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.core.externaltools/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From eaa3ac17f344b48134ddc5cebf426b2d852af7f2 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Thu, 30 Jan 2025 10:48:00 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/debug/org.eclipse.core.externaltools/META-INF/MANIFEST.MF b/debug/org.eclipse.core.externaltools/META-INF/MANIFEST.MF
index 169587e22e..2be9d48ae2 100644
--- a/debug/org.eclipse.core.externaltools/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.core.externaltools/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-Localization: plugin
 Bundle-SymbolicName: org.eclipse.core.externaltools;singleton:=true
-Bundle-Version: 1.3.400.qualifier
+Bundle-Version: 1.3.500.qualifier
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
  org.eclipse.debug.core;bundle-version="[3.9.0,4.0.0)",
  org.eclipse.core.variables;bundle-version="[3.2.800,4.0.0)"
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

 1 668 files   -    87   1 668 suites   - 87   1h 11m 7s ⏱️ - 29m 56s
 3 573 tests  -   597   3 551 ✅  -   596   22 💤  - 1  0 ❌ ±0 
11 316 runs   - 1 791  11 154 ✅  - 1 786  162 💤  - 5  0 ❌ ±0 

Results for commit 0eaee71. ± Comparison against base commit 29bc65f.

This pull request removes 597 tests.

AllTests ApiDocTest ‑ testTopicsReference
AllTests LinkTest ‑ testAllLinks
AllTests TocLinkChecker ‑ testJdtIsvGenerated
AllTests TocLinkChecker ‑ testJdtIsvStatic
AllTests TocLinkChecker ‑ testJdtUser
AllTests TocLinkChecker ‑ testPdeUserGenerated
AllTests TocLinkChecker ‑ testPdeUserStatic
AllTests TocLinkChecker ‑ testPlatformIsvGenerated
AllTests TocLinkChecker ‑ testPlatformIsvStatic
AllTests TocLinkChecker ‑ testPlatformUser
…

♻️ This comment has been updated with latest results.

[mickaelistria]

As mentioned in the call, some example using this API proposal would be helpful. There is probably some content in org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations you can tweak to leverage this API.

[ruspl-afed]

I'm not sure why it is is failing @HannesWell

11:59:41.178 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.11-SNAPSHOT:verify (verify) on project org.eclipse.debug.core: 
Execute ApiApplication failed: InvocationTargetException: EmptyStackException -> [Help 1]

[HannesWell]

I'm not sure why it is is failing @HannesWell

11:59:41.178 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.11-SNAPSHOT:verify (verify) on project org.eclipse.debug.core: 
Execute ApiApplication failed: InvocationTargetException: EmptyStackException -> [Help 1]

It looks like your change is breaking API-tools^^
I have replayed the Jenkins build the -e set to get an more informative stack-trace:
https://ci.eclipse.org/platform/job/eclipse.platform/job/PR-1669/7/

[ruspl-afed]

Thank you @HannesWell for your assistance.

It looks like your change is breaking API-tools^^

WOW! But that wasn't part of my plan. It looks like this issue was already reported. Interesting, may be I can have a deeper look to it soon.

And still interested in your feedback regarding PR content.