[WIP] [#23] Refactor meta-iceoryx2 #28
Conversation
dkroenke
force-pushed
the
yocto-iox2-23-refactor-meta-iceoryx2
branch
from
6a8f6ca to
3df0cf4
Compare
elBoberido
left a comment
elBoberido
left a comment
There was a problem hiding this comment.
Looks good. The changes from the comments could also be added in another PR.
Would it be possible to set a preferred version? Making v0.7.0 the preferred version and then v0.8.0 with the next release
To cover all potentials revisions when choosing a particular version of iceoryx2 we cannot rely only on main branch to include the releases
dkroenke
force-pushed
the
yocto-iox2-23-refactor-meta-iceoryx2
branch
from
ff7abb1 to
fce8913
Compare
elBoberido
left a comment
elBoberido
left a comment
There was a problem hiding this comment.
Looks good but the last two commits do not have an issue number
dkroenke
force-pushed
the
yocto-iox2-23-refactor-meta-iceoryx2
branch
from
fce8913 to
d47fef9
Compare
| PREFERRED_VERSION_iceoryx-hoofs-subset = "${ICEORYX2_VERSION}" | ||
| PREFERRED_VERSION_iceoryx-platform-minimal = "${ICEORYX2_VERSION}" |
There was a problem hiding this comment.
Hmm, not sure if this is a good idea. Maybe we should get rid of the iceoryx_hoofs recipes completely once v0.8.0 is out and the users switched to that version. What do you think?
| Since we introduced package versions in `meta-iceoryx2` layer config | ||
| it may can happen that |
There was a problem hiding this comment.
It seems there is something missing in this sentence
|
|
||
| PREFERRED_VERSION_iceoryx-hoofs-subset = "${ICEORYX2_VERSION}" | ||
| PREFERRED_VERSION_iceoryx-platform-minimal = "${ICEORYX2_VERSION}" | ||
| PREFERRED_VERSION_iceoryx2 = "${ICEORYX2_VERSION}" |
There was a problem hiding this comment.
It seems there is a shift regarding the notation to use : instead of _. Do you know if PREFERRED_VERSION:iceoryx2 would also work?
|
|
||
| inherit cmake | ||
|
|
||
| DEPENDS = "iceoryx2 iceoryx2-cmake-modules" |
There was a problem hiding this comment.
Do you know if we need to specify the iceoryx2 version here? I mean that if one builds iceoryx2-c_0.7 that automatically iceoryx2_0.7 is used?
No description provided.