refactor: supports multi protocols dsp-http #4514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Supports multi protocols in DspRequest and DspHttpRemoteMessageDispatcherImpl
ProtocolVersion
forv0.8
default one, bind in the default controllers without a version in the path.DspProtocolTypeTransformerRegistry
spi for fetching the rightTypeTransformerRegistry
given a protocol.DspProtocolParser
for parsing the protocol formatdataspace-protocol-http:<version>
into aProtocolVersion
ProtocolRemoteMessage
for holding the protocol and changing it in ingress onDspRequestHandlerImpl
PostDspHttpRequestFactory
andGetDspHttpRequestFactory
uses theDspProtocolParser
for extracting the right protocol version from aRemoteMessage#protocol
Why it does that
supporting multiple dsp protocols
Further notes
Currently both
v0.8
and2024/1
have the same transformers registered. In subsequent PRs the2024/1
should be fixed to point to the right namespace.The
JsonLd
context refactor has no been applied in this PR. Currently they still use the sameJsonLD
configuration under theDSP
scope.Linked Issue(s)
Closes #4507
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.