refactor: avoid potential unnecessary store accesses on dataset resolution #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
force-pushed
the
4499-avoid-unnecessary-policy-store-accesses
branch
from
ca7819d
to
f7078b8
Compare
...main/java/org/eclipse/edc/connector/controlplane/catalog/ContractDefinitionResolverImpl.java
Outdated
Show resolved
Hide resolved
...rg/eclipse/edc/connector/controlplane/contract/validation/ContractValidationServiceImpl.java
Show resolved
Hide resolved
...ain/java/org/eclipse/edc/connector/controlplane/catalog/spi/ResolvedContractDefinitions.java
Show resolved
Hide resolved
...main/java/org/eclipse/edc/connector/controlplane/catalog/spi/ContractDefinitionResolver.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/edc/connector/controlplane/catalog/spi/ResolvedContractDefinitions.java
Outdated
Show resolved
Hide resolved
ndr-brt
force-pushed
the
4499-avoid-unnecessary-policy-store-accesses
branch
from
f7078b8
to
f0137f8
Compare
paullatzelsperger
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Refactors
ContractDefinitionResolverandDatasetResolveradding a thread local cache to diminish database accesses.Why it does that
Avoid potential multiple and unnecessary calls to
PolicyDefinitionStore.findById.In cases where access policy id is the same as contract policy id this will halve database accesses, will also provide advantages where same policies are used for different contract negotiations
Further notes
Linked Issue(s)
Closes #4499
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.