Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add state field on DataPlaneInstance response #4350

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

wolf4ood
Copy link
Contributor

What this PR changes/adds

add state field on DataPlaneInstance response

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4335

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Jul 10, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Jul 10, 2024
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the state field on the DataPlaneInstanceSchema and example, so it will require (and justify) a change in the management version file

@wolf4ood
Copy link
Contributor Author

@ndr-brt added

@wolf4ood wolf4ood requested a review from ndr-brt July 10, 2024 07:58
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.30%. Comparing base (7f20ba5) to head (4f2868e).
Report is 349 commits behind head on main.

Files Patch % Lines
...c/to/JsonObjectToDataPlaneInstanceTransformer.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4350      +/-   ##
==========================================
+ Coverage   71.74%   75.30%   +3.56%     
==========================================
  Files         919     1053     +134     
  Lines       18457    21175    +2718     
  Branches     1037     1182     +145     
==========================================
+ Hits        13242    15946    +2704     
+ Misses       4756     4710      -46     
- Partials      459      519      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood merged commit 5e210f9 into eclipse-edc:main Jul 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add state on DataPlaneInstance response
4 participants