Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid thread blocking in ParallelSink #4333

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jul 4, 2024

What this PR changes/adds

Wrap the ParallelSink logic into an async bloc.

Why it does that

avoid blocking behavior on long-running transfers

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4330

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the bug Something isn't working label Jul 4, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.25%. Comparing base (7f20ba5) to head (d86dec0).
Report is 338 commits behind head on main.

Files Patch % Lines
...dc/connector/dataplane/util/sink/ParallelSink.java 72.22% 4 Missing and 1 partial ⚠️
...taplane/framework/DataPlaneFrameworkExtension.java 20.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4333      +/-   ##
==========================================
+ Coverage   71.74%   75.25%   +3.50%     
==========================================
  Files         919     1053     +134     
  Lines       18457    21136    +2679     
  Branches     1037     1183     +146     
==========================================
+ Hits        13242    15905    +2663     
+ Misses       4756     4714      -42     
- Partials      459      517      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit a5c736e into eclipse-edc:main Jul 4, 2024
24 checks passed
@ndr-brt ndr-brt deleted the 4330-fix-parallel-sink branch July 4, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants