docs: add decision record about optional params in CatalogRequest #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
the
documentation
paullatzelsperger
requested review from
wolf4ood,
jimmarino,
ndr-brt and
bscholtes1A
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4325 +/- ##
==========================================
+ Coverage 71.74% 75.24% +3.50%
==========================================
Files 919 1053 +134
Lines 18457 21139 +2682
Branches 1037 1183 +146
==========================================
+ Hits 13242 15907 +2665
+ Misses 4756 4714 -42
- Partials 459 518 +59 ☔ View full report in Codecov by Sentry. |
ndr-brt
reviewed
Jul 3, 2024
docs/developer/decision-records/2024-07-03-additional-catalogrequest-param/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2024-07-03-additional-catalogrequest-param/README.md
Outdated
Show resolved
Hide resolved
paullatzelsperger
force-pushed
the
docs/decision-record_about_additional_param_in_catalogrequest
branch
from
98ae4b9
to
f49d066
Compare
jimmarino
approved these changes
Jul 5, 2024
wolf4ood
approved these changes
Jul 5, 2024
ndr-brt
approved these changes
Jul 5, 2024
paullatzelsperger
deleted the
docs/decision-record_about_additional_param_in_catalogrequest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
adds a decision record about adding a new, optional
parametersfield to theCatalogRequestbodyWhy it does that
documentation
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4322
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.