Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): switch to new namespace for jakarta.json-api library #4272

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jun 14, 2024

What this PR changes/adds

Changes the group id fo the jakarta.json api library.
To do that I had to add a parsson implementation, because from version 2.1.0 api and implementation have been separated (ref. https://github.com/jakartaee/jsonp-api/releases/tag/2.1.0-RELEASE)

Why it does that

Briefly state why the change was necessary.

Further notes

  • took the opportunity to rename the reference in the version catalog to the standard notation
  • speed up DataPlaneSelectorEndToEndTest and remove related deprecation usages

Linked Issue(s)

Closes #4271

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the build Anything related to the CI/CD Pipeline on Github Actions label Jun 14, 2024
@ndr-brt ndr-brt requested a review from wolf4ood June 14, 2024 10:19
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.04%. Comparing base (7f20ba5) to head (f6adb01).
Report is 304 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4272      +/-   ##
==========================================
+ Coverage   71.74%   75.04%   +3.29%     
==========================================
  Files         919     1046     +127     
  Lines       18457    20982    +2525     
  Branches     1037     1171     +134     
==========================================
+ Hits        13242    15745    +2503     
+ Misses       4756     4724      -32     
- Partials      459      513      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 58af944 into eclipse-edc:main Jun 14, 2024
16 checks passed
@ndr-brt ndr-brt deleted the 4271 branch June 14, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Anything related to the CI/CD Pipeline on Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from org.glassfish:jakarta.json to jakarta.json:jakarta.json-api
3 participants