Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor AudienceResolver with Result as return #4266

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Jun 12, 2024

What this PR changes/adds

refactor AudienceResolver with Result as return

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4265

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Jun 13, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Jun 13, 2024
@wolf4ood wolf4ood force-pushed the feat/4265_result_on_audience_resolver branch from 9757a40 to 6f31845 Compare June 13, 2024 07:55
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.03%. Comparing base (7f20ba5) to head (45288fe).
Report is 302 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4266      +/-   ##
==========================================
+ Coverage   71.74%   75.03%   +3.28%     
==========================================
  Files         919     1046     +127     
  Lines       18457    20986    +2529     
  Branches     1037     1171     +134     
==========================================
+ Hits        13242    15746    +2504     
+ Misses       4756     4727      -29     
- Partials      459      513      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood force-pushed the feat/4265_result_on_audience_resolver branch from 6f31845 to 0e9142f Compare June 13, 2024 08:22
@wolf4ood wolf4ood force-pushed the feat/4265_result_on_audience_resolver branch from 0e9142f to 45288fe Compare June 13, 2024 09:08
@wolf4ood wolf4ood marked this pull request as ready for review June 13, 2024 09:40
@wolf4ood wolf4ood merged commit 8c2ca13 into eclipse-edc:main Jun 13, 2024
18 checks passed
@wolf4ood wolf4ood deleted the feat/4265_result_on_audience_resolver branch June 13, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AudienceResolver should support fallible resolve
3 participants