Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: data-plane self unregistration #4249

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jun 7, 2024

What this PR changes/adds

Make the data plane "unregister" itself instead of "delete".

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4238

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added enhancement New feature or request dpf Feature related to the Data Plane Framework labels Jun 7, 2024
@ndr-brt ndr-brt requested a review from wolf4ood June 7, 2024 09:22
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.03%. Comparing base (7f20ba5) to head (08dcbf6).
Report is 398 commits behind head on main.

Files Patch % Lines
...plane/selector/spi/instance/DataPlaneInstance.java 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4249      +/-   ##
==========================================
+ Coverage   71.74%   75.03%   +3.28%     
==========================================
  Files         919     1046     +127     
  Lines       18457    20980    +2523     
  Branches     1037     1169     +132     
==========================================
+ Hits        13242    15742    +2500     
+ Misses       4756     4726      -30     
- Partials      459      512      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 8932966 into eclipse-edc:main Jun 7, 2024
18 checks passed
@ndr-brt ndr-brt deleted the 4238-data-plane-unregister branch June 7, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dpf Feature related to the Data Plane Framework enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make data plane self registration unregister the instance
3 participants