Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add data-plane-instance heartbeat #4230

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jun 3, 2024

What this PR changes/adds

Adds a DataPlaneSelectorManager that takes care of checking the dataplanes availability.

BREAKING CHANGE: there's a new lease_id column added to the edc_data_plane_instance table, please check the diff for details.

Why it does that

Avoid failing transfers for unavabilable data planes.

Further notes

  • note that data-plane-self-registration still "deletes" itself instead of "unregistering". It will fixed in a subsequent pr

Linked Issue(s)

Closes #4220

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Jun 3, 2024
@ndr-brt ndr-brt requested a review from wolf4ood June 3, 2024 07:33
Comment on lines +71 to +74
var builder = Builder.newInstance()
.url(url)
.lastActive(lastActive)
.turnCount(turnCount)

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Builder.turnCount
should be avoided because it has been deprecated.
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 72.39819% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 75.28%. Comparing base (7f20ba5) to head (3c901cc).
Report is 287 commits behind head on main.

Files Patch % Lines
...dataplane/selector/DataPlaneSelectorExtension.java 0.00% 20 Missing ⚠️
...selector/spi/instance/DataPlaneInstanceStates.java 0.00% 10 Missing ⚠️
.../selector/store/sql/SqlDataPlaneInstanceStore.java 82.50% 6 Missing and 1 partial ⚠️
...plane/selector/spi/instance/DataPlaneInstance.java 79.41% 7 Missing ⚠️
...ane/selector/spi/store/DataPlaneInstanceStore.java 0.00% 4 Missing ⚠️
...selector/manager/DataPlaneSelectorManagerImpl.java 90.62% 3 Missing ⚠️
...tor/dataplane/client/DataPlaneSignalingClient.java 90.90% 1 Missing and 1 partial ⚠️
...c/connector/core/CoreDefaultServicesExtension.java 0.00% 1 Missing ⚠️
...nsfer/TransferProcessDefaultServicesExtension.java 0.00% 1 Missing ⚠️
...tor/DataPlaneSelectorDefaultServicesExtension.java 0.00% 1 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4230      +/-   ##
==========================================
+ Coverage   71.74%   75.28%   +3.53%     
==========================================
  Files         919     1040     +121     
  Lines       18457    20755    +2298     
  Branches     1037     1155     +118     
==========================================
+ Hits        13242    15625    +2383     
+ Misses       4756     4619     -137     
- Partials      459      511      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt force-pushed the 4220-heartbeat-data-plane branch 3 times, most recently from 40e2e47 to 43a1ff3 Compare June 3, 2024 10:07
@ndr-brt ndr-brt force-pushed the 4220-heartbeat-data-plane branch from 43a1ff3 to 3c901cc Compare June 3, 2024 11:45
@ndr-brt ndr-brt added the breaking-change Will require manual intervention for version update label Jun 5, 2024
@ndr-brt ndr-brt merged commit 703502f into eclipse-edc:main Jun 6, 2024
20 checks passed
@ndr-brt ndr-brt deleted the 4220-heartbeat-data-plane branch June 6, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Will require manual intervention for version update enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heartbeat from data-plane-selector to dataplane
3 participants