feat(test): convert all postgres tests to use testcontainers #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
refactoring
|
edit: this is done now, so it should be reviewable |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3268 +/- ##
==========================================
+ Coverage 66.19% 72.42% +6.22%
==========================================
Files 846 843 -3
Lines 16998 17035 +37
Branches 940 948 +8
==========================================
+ Hits 11252 12337 +1085
+ Misses 5375 4305 -1070
- Partials 371 393 +22
☔ View full report in Codecov by Sentry. |
paullatzelsperger
force-pushed
the
feature/convert_postgres-tests_to_testcontainers
branch
2 times, most recently
from
536dfba
to
f107245
Compare
paullatzelsperger
force-pushed
the
feature/convert_postgres-tests_to_testcontainers
branch
from
f107245
to
97d4227
Compare
paullatzelsperger
requested review from
ndr-brt,
bscholtes1A and
jimmarino
as code owners
wolf4ood
approved these changes
Jul 6, 2023
bjungs
pushed a commit
to imec-int/edc
that referenced
this pull request
Aug 18, 2023
…-edc#3268) feat: consolidate tractus-x HashiCorp Vault impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR converts all
@PostgresqlDbIntegrationTestinstances to@ComponentTestsusing Testcontainers. All tests - except E2e, that is.Converting the E2E tests over seemed to be quite a large undertaking, given how we are using test extensions and all the static initialization stuff etc. If needed, we can do it in a subsequent PR.
Consequently, the
@PostgresqlDbIntegrationTestannotation is only used for E2E tests anymore.Why it does that
Decision to use test containers.
Further notes
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.