Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement get dataset dsp endpoint #3243

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jun 28, 2023

What this PR changes/adds

Implement DSP /catalog/datasets/{id} endpoint

Why it does that

dsp compliance

Further notes

  • now the Dataset id is the same as the Asset id.

Linked Issue(s)

Closes #3220
Closes #3231

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels Jun 28, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 34.42% and project coverage change: -57.34 ⚠️

Comparison is base (83df482) 65.94% compared to head (a2026bd) 8.60%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #3243       +/-   ##
==========================================
- Coverage   65.94%   8.60%   -57.34%     
==========================================
  Files         843     842        -1     
  Lines       16871   16891       +20     
  Branches      925     932        +7     
==========================================
- Hits        11126    1454     -9672     
- Misses       5375   15392    +10017     
+ Partials      370      45      -325     
Impacted Files Coverage Δ
...pse/edc/connector/catalog/DatasetResolverImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...or/service/catalog/CatalogProtocolServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
.../eclipse/edc/service/spi/result/ServiceResult.java 0.00% <0.00%> (-47.83%) ⬇️
...atalog/api/controller/DspCatalogApiController.java 93.44% <100.00%> (+3.44%) ⬆️

... and 581 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndr-brt ndr-brt merged commit 2999513 into eclipse-edc:main Jun 29, 2023
@ndr-brt ndr-brt deleted the 3220-dataset-endpoint branch June 29, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
4 participants