Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: get rid of the Dtos on management api #3267

Closed
5 of 7 tasks
ndr-brt opened this issue Jul 4, 2023 · 0 comments · Fixed by #3309
Closed
5 of 7 tasks

refactor: get rid of the Dtos on management api #3267

ndr-brt opened this issue Jul 4, 2023 · 0 comments · Fixed by #3309
Assignees
@ndr-brt
Labels
api Feature related to the (REST) api refactoring Cleaning up code and dependencies
Milestone
Milestone 10

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Jul 4, 2023 •
edited
Loading

Feature Request

After the introduction of the Json-LD semantics and the homebrewed validators, the Dto's are not more useful, we can rely on a schema defined (see #3265) and then having a single transformation from JsonObject to the domain model objects.

Which Areas Would Be Affected?

management api

Why Is the Feature Desired?

cleanup

  • ContractDefinition
  • PolicyDefinition
  • Asset
  • ContractNegotiation
  • TransferProcess
  • ContractAgreement
  • QuerySpec / Criterion
@ndr-brt ndr-brt added refactoring Cleaning up code and dependencies api Feature related to the (REST) api labels Jul 4, 2023
@ndr-brt ndr-brt added this to the Milestone 10 milestone Jul 4, 2023
@ndr-brt ndr-brt self-assigned this Jul 4, 2023
This was referenced Jul 5, 2023
Closed
Closed
This was referenced Jul 17, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndr-brt ndr-brt

Labels
api Feature related to the (REST) api refactoring Cleaning up code and dependencies
Projects
None yet
Milestone
Milestone 10
Development

Successfully merging a pull request may close this issue.

refactor: remove DTOs from management-api Think-iT-Labs/edc-connector
1 participant
@ndr-brt