Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge *RequestDto with *UpdateDto #2870

Closed
ndr-brt opened this issue May 2, 2023 · 2 comments
Closed

refactor: merge *RequestDto with *UpdateDto #2870

ndr-brt opened this issue May 2, 2023 · 2 comments
Labels
dataspace-protocol related to the dataspace protocol refactoring Cleaning up code and dependencies
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented May 2, 2023

Feature Request

currently, for the Asset, ContractDefinition and PolicyDefinition endpoints we have two different objects representing the request body for creation and update.
Specifically, the UpdateDto miss the id property, but in fact it is something that could (and maybe, should) specified in the request body (other than in the request path).

Giving this, we could remove the WrapperDto classes and related transformers.

NOTE: this could be done only after the current deprecated is removed, otherwise this will be a breaking change.

Which Areas Would Be Affected?

management api

Why Is the Feature Desired?

refactor

Solution Proposal

If possible, provide a (brief!) solution proposal.

@ndr-brt ndr-brt added refactoring Cleaning up code and dependencies dataspace-protocol related to the dataspace protocol labels May 2, 2023
@ndr-brt ndr-brt added this to the Milestone 10 milestone May 2, 2023
@github-actions
Copy link

This issue is stale because it has been open for 28 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Jun 24, 2023
@juliapampus juliapampus removed the stale Open for x days with no activity label Jun 26, 2023
@ndr-brt
Copy link
Member Author

ndr-brt commented Jul 5, 2023

superseded by #3267

@ndr-brt ndr-brt closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol refactoring Cleaning up code and dependencies
Projects
None yet
Development

No branches or pull requests

2 participants