Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate multiple implementations of HashicorpVault #3254

Closed
2 of 3 tasks
paullatzelsperger opened this issue Jun 30, 2023 · 1 comment · Fixed by #3255 or #3266
Closed
2 of 3 tasks

Consolidate multiple implementations of HashicorpVault #3254

paullatzelsperger opened this issue Jun 30, 2023 · 1 comment · Fixed by #3255 or #3266
Labels
core feature enhancement New feature or request

Comments

@paullatzelsperger
Copy link
Member

paullatzelsperger commented Jun 30, 2023 •
edited
Loading

Feature Request

Currently there is one implementation of the HashiCorp Vault directly in the Connector repository, but there's also one in Tractus-X

We should consolidate these two implementations and host them upstream in the Connector repo. For example, the downstream impl contains a health check, which the upstream impl lacks.

When doing that, we may want to relax our guidelines towards Test containers, since the Tractus-X impl heavily relies on them.

Which Areas Would Be Affected?

control plane

Why Is the Feature Desired?

Consolidate efforts, avoid code duplication.

Solution Proposal
@paullatzelsperger paullatzelsperger added feature_request New feature request, awaiting triage triage all new issues awaiting classification labels Jun 30, 2023
@paullatzelsperger paullatzelsperger mentioned this issue Jun 30, 2023
Merged
@paullatzelsperger
Copy link
Member Author

reopened, because impl not done yet.

@paullatzelsperger paullatzelsperger added enhancement New feature or request core feature and removed feature_request New feature request, awaiting triage triage all new issues awaiting classification labels Jul 4, 2023
@paullatzelsperger paullatzelsperger mentioned this issue Jul 4, 2023
Merged
@paullatzelsperger paullatzelsperger mentioned this issue Jul 7, 2023
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core feature enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@paullatzelsperger