Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace HashiCorp vault implementation with upstream #589

Closed
paullatzelsperger opened this issue Jul 7, 2023 · 2 comments
Closed

Replace HashiCorp vault implementation with upstream #589

paullatzelsperger opened this issue Jul 7, 2023 · 2 comments
Assignees
@paullatzelsperger
Labels
enhancement New feature or request refactoring Refactoring, does not add functionality

Comments

@paullatzelsperger
Copy link
Contributor

paullatzelsperger commented Jul 7, 2023 •
edited
Loading

WHAT

Remove the Tractusx-EDC impl. of Hashicorp Vault and replace its usage with the one that was upstreamed in eclipse-edc/Connector#3254.

WHY

no point in having multiple identical impls.

FURTHER REMARKS

can be done as soon as EDC version 0.1.4 or later is used
@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Jul 7, 2023
@paullatzelsperger paullatzelsperger self-assigned this Jul 7, 2023
@paullatzelsperger paullatzelsperger added the refactoring Refactoring, does not add functionality label Jul 7, 2023
@paullatzelsperger
Copy link
Contributor Author

implicitly fixed by #674

@florianrusch-zf
Copy link
Contributor

florianrusch-zf commented Aug 9, 2023 •
edited
Loading

@paullatzelsperger do you know, if this change will contain breaking changes in the configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paullatzelsperger paullatzelsperger

Labels
enhancement New feature or request refactoring Refactoring, does not add functionality
Projects
EDC Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paullatzelsperger @florianrusch-zf