Make Agent Register request asynchronous #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkemel
force-pushed
the
async-register
branch
4 times, most recently
from
8790825
to
4995715
Compare
|
Ready for review. GH Integration tests failing at the prepare stage currently, probably infra issue |
|
/packit test --labels valgrind |
mkemel
force-pushed
the
async-register
branch
from
4995715
to
1ff7a55
Compare
ArtiomDivak
reviewed
Oct 16, 2024
mkemel
force-pushed
the
async-register
branch
2 times, most recently
from
61dbf93
to
4fb58b2
Compare
|
Moved the PR back to draft, found a memory issue |
mkemel
force-pushed
the
async-register
branch
2 times, most recently
from
1e4b61e
to
6db1932
Compare
engelmi
reviewed
Oct 29, 2024
mkemel
force-pushed
the
async-register
branch
4 times, most recently
from
0331f47
to
7027c07
Compare
The "Register" agent->controller method call could get stuck when the IP address configured as ControllerHost does not exist. This timeout of about 2 seconds could completely occupy the event loop and would not allow other calls on the DBus API of the Agent. Making the "Register" method call asynchronous we allow the event loop to stay unoccupied and be able to accept SwitchController request. Resolves: eclipse-bluechi#950 Signed-off-by: Mark Kemel <[email protected]>
mkemel
force-pushed
the
async-register
branch
from
7027c07
to
4ad6f94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Register" agent->controller method call could get stuck when the IP address configured as ControllerHost does not exist. This timeout of about 2 seconds could completely occupy the event loop and would not allow other calls on the DBus API of the Agent.
Making the "Register" method call asynchronous we allow the event loop to stay unoccupied and be able to accept SwitchController request.
Resolves: #950
Resolves: #966