Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk.deps: Move test depencies to extra dev section #369

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

JGrothoff
Copy link
Contributor

@JGrothoff JGrothoff commented Jan 16, 2025

Move test depencies to extra dev section

Some sdk dependencies, that are only necessary for testing, are included in the mandatory dependencies.

The development dependencies can be moved to the existing optional-dependencies dev section, to make the library footprint smaller, when it is used without modifications.

I assume following deps can be moved:

  • schemathesis: imported in test_http.py
  • jsonschema: imported in test_http.py and test_json_serialization.py
  • hypothesis: imported in test_http.py
  • types-python-dateutil: used for typechecking
  • lxml-stubs: used for typechecking

Copy link
Contributor

@s-heppner s-heppner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for cleaning up these dependencies!
You are correct, the ones you moved are only necessary during development or testing.

Could you please adapt the dependency section of /sdk/README.md? (https://github.com/eclipse-basyx/basyx-python-sdk/blob/main/sdk/README.md#dependencies)
After that, we can merge this PR.

@JGrothoff JGrothoff requested a review from s-heppner January 20, 2025 11:24
Copy link
Contributor

@s-heppner s-heppner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@s-heppner s-heppner merged commit 86a8333 into eclipse-basyx:develop Jan 20, 2025
14 checks passed
@JGrothoff JGrothoff deleted the fix/optional-dev-deps branch January 20, 2025 15:13
@s-heppner s-heppner added this to the Release v1.1.1 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants