Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reducing the "scope" of new_sorted_actual_scores #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacobvosmaer
Copy link
Contributor

I have refactored the calculation of sorted_actual_scores in best_match_for_query(). The assignment sorted_actual_scores = new_sorted_actual_scores was occurring later than necessary, making it harder to see that the sole purpose of the variable new_sorted_actual_scores is as a temporary variable for the removal of duplicates.

Would you agree that this improves the readability of the code?

@ghost ghost assigned alnesbit Mar 7, 2012
@alnesbit
Copy link
Contributor

alnesbit commented Mar 7, 2012

Thanks. You're right that the calculation of sorted_actual_scores could be better positioned, and I agree this improves readability. I will merge this patch after testing.

@alnesbit
Copy link
Contributor

Manually applied, committed and merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants