Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout element is wrongly allowed to be empty #524

Open
nigelmegitt opened this issue Nov 15, 2019 · 0 comments
Open

layout element is wrongly allowed to be empty #524

nigelmegitt opened this issue Nov 15, 2019 · 0 comments
Assignees
@nigelmegitt
Labels
bug pending PR merge

Comments

@nigelmegitt
Copy link
Collaborator

Tech3350 v1.2 specifies that there must be at least 1 region element in a layout element, and in Part 1, that the layout element must be present. Tech3370 relaxes the constraint that layout must be present, but not the constraint that if a layout element exists it must have at least 1 region child. Currently the XSD and code wrongly allows empty layout elements.
@nigelmegitt nigelmegitt self-assigned this Nov 15, 2019
nigelmegitt added a commit that referenced this issue Nov 15, 2019
@nigelmegitt
Make region required in Part 3 docs
d1e5b63 
Updates the XSD to match the spec, which requires that if a `layout` element is present, it must have at least one `region` child. In Part 3 the `layout` element itself is optional, but in Part 1 it is required.

Also update the test XML templates to be valid: many of them had invalid empty `layout` elements.

Fix the Segmenter so that if a `layout` element has no `region` children, the `layout` element itself is removed.

Closes #524.
@nigelmegitt nigelmegitt mentioned this issue Nov 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nigelmegitt nigelmegitt

Labels
bug pending PR merge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nigelmegitt