added support for Spansion S25FL1-K 64Mb #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We do not have a S25FL1-K 64Mb available, but I found a 16Mb version to perform some tests. |
|
Unfortunately, it is a SL25FL016K, which does not seem compliant with S25FL1-K. Spansion SPI data flash series are notoriously ugly as they may identify with same IDs but expose incompatible instruction set, not mentioning their non-linear erase page size... |
|
Beware that the proposed patch is invalid: |
|
You are right, it should be 0x40<<17 - for 64Mb (8MB) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.