Skip to content

Fix bug in ft_binding column #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Fix bug in ft_binding column #853

merged 1 commit into from
Apr 1, 2025

Conversation

Swaathik
Copy link
Contributor

Purpose

https://www.ebi.ac.uk/panda/jira/browse/TRM-32511

Approach

Looking at the past commit reference, I believe 'BINDING' was added as featureType for website code to recognise the data from Proteins API. At that time, we were adding the type as tooltip title in here instead of protvista-uniprot. Since all tooltip work is handled by protvista, we do not need it here. Hence, there is no clash between BINDING and Binding site column as the former doesn't exist in rest API's feature types

Testing

What test(s) did you write to validate and verify your changes?

Checklist

  • My PR is scoped properly, and “does one thing only”
  • I have reviewed my own code
  • I have checked that linting checks pass and type safety is respected
  • I have checked that tests pass and coverage has at least improved, and if not explained the reasons why
  • If needed, the changes have been previewed (eg on wwwdev) by all interested parties.

@Swaathik Swaathik requested a review from dlrice March 31, 2025 12:37
@Swaathik Swaathik merged commit 597a4f7 into main Apr 1, 2025
1 check passed
@Swaathik Swaathik deleted the fix-binding branch April 1, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants