Skip to content

Supporting data landing page #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

Swaathik
Copy link
Contributor

@Swaathik Swaathik commented Mar 28, 2025

Purpose

Landing page - https://www.ebi.ac.uk/panda/jira/browse/TRM-32387
CFDE form - https://www.ebi.ac.uk/panda/jira/browse/TRM-32211

Approach

Created new landing page with the data integration form

Testing

What test(s) did you write to validate and verify your changes?

Checklist

  • My PR is scoped properly, and “does one thing only”
  • I have reviewed my own code
  • I have checked that linting checks pass and type safety is respected
  • I have checked that tests pass and coverage has at least improved, and if not explained the reasons why
  • If needed, the changes have been previewed (eg on wwwdev) by all interested parties.

@Swaathik Swaathik marked this pull request as ready for review April 30, 2025 14:51
</div>
{/* Data integration form */}
<div className="uniprot-grid-cell--small-span-12 uniprot-grid-cell--medium-span-6">
<h2>Expand Your Reach: Connect Your Database with UniProt</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to push the "Expand Your Reach: Connect Your Database with UniProt" below the automatic annotations to distinguish it from the rest of the namespaces? At the same time, the form seems related to Cross-referenced Databases so is there a way we could move these two things closer in the page or somehow indicate a relationship?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants