-
Notifications
You must be signed in to change notification settings - Fork 2
Feature track table improvements #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble-improvements-no-button
…ble-improvements-no-button
Swaathik
reviewed
Apr 2, 2025
yield end; | ||
} | ||
|
||
export async function* rangeTimed( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel an explanation in the comments would be more helpful when we refer to it in the future
Swaathik
approved these changes
Apr 2, 2025
…ents-no-button Remove navigate to feature button.
…rovements More feature track table improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Approach
useAnimateRange
: animates between initial and final nightingale navigation (start, end) pairs.useFeatureViewScrollSync
: synchronizes the movement of the nightingale navigation and the table. Note sync only happens from navigation to table and not the other way around.Testing
Added tests
Checklist