Skip to content

Feature track table improvements #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Apr 30, 2025
Merged

Conversation

dlrice
Copy link
Contributor

@dlrice dlrice commented Mar 6, 2025

Purpose

Approach

  • useAnimateRange: animates between initial and final nightingale navigation (start, end) pairs.
  • useFeatureViewScrollSync: synchronizes the movement of the nightingale navigation and the table. Note sync only happens from navigation to table and not the other way around.
  • Add utility functions to support these

Testing

Added tests

Checklist

  • My PR is scoped properly, and “does one thing only”
  • I have reviewed my own code
  • I have checked that linting checks pass and type safety is respected
  • I have checked that tests pass and coverage has at least improved, and if not explained the reasons why
  • If needed, the changes have been previewed (eg on wwwdev) by all interested parties.

@dlrice dlrice marked this pull request as ready for review March 24, 2025 11:08
yield end;
}

export async function* rangeTimed(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel an explanation in the comments would be more helpful when we refer to it in the future

@dlrice dlrice merged commit 12f1677 into main Apr 30, 2025
1 check passed
@dlrice dlrice deleted the feature-track-table-improvements branch April 30, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants