Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptor any type #99

Merged
merged 18 commits into from
Jan 31, 2025
Merged

Descriptor any type #99

merged 18 commits into from
Jan 31, 2025

Conversation

henrikjacobsenfys
Copy link
Member

Added a descriptor that can take any type.

I accidentally based this branch off of the DescriptorArray branch, but only DescriptorAnyType and its tests have been modified, so it should be fine.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@henrikjacobsenfys henrikjacobsenfys added the enhancement New feature or request, PR label label Jan 29, 2025
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You might want to expand on the DescriptorAnyType docstring to mention the reason behind creating this class as it may be useful for the future refactoring.

@henrikjacobsenfys henrikjacobsenfys merged commit 4023f14 into develop Jan 31, 2025
32 checks passed
@henrikjacobsenfys henrikjacobsenfys deleted the DescriptorAnyType branch January 31, 2025 13:16
@henrikjacobsenfys henrikjacobsenfys restored the DescriptorAnyType branch January 31, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request, PR label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants