fix module load environment in conda and Anaconda easyblock #3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 tasks
lexming
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I totally misunderstood the purpose of the environment settings in the conda (#3562) and Anaconda (#3577) easyblocks. The goal is not to set some generic paths, but to unset linking paths to libraries in the conda environment.
The actual goal is avoiding that the conda environment is used by any other software external to it, neither at runtime or build time. Hence, this can logically be extended to include paths.
This PR replaces the default paths set by conda easyblock in
module_load_environmentwith the deletion of those variables related to search paths for linking and includes that are unwanted in the conda module environment.Depends on easybuilders/easybuild-framework#4655