Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Cargo variables also for extensions #3576

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Feb 5, 2025

(created using eb --new-pr)

This is required for e.g. CargoPythonBundle as otherwise $CARGO_HOME won't be set for the extensions.

I also noticed a fix for checksums in dict format I didn't include in #3483
I split that to a separate commit but still included it here.

Test Report

We usually use `{'source': checksum}` for checksums so `src['checksum']`
might return such a dict instead of a checksum.
This can be observed in `uv-0.2.30-GCCcore-13.3.0.eb`:
```
{'reqwest-middleware-0.3.2-21ceec9a5fd2e8d6f71c3ea2999078fecbd13cbe.tar.gz': None}
{'reqwest-retry-0.7.0-21ceec9a5fd2e8d6f71c3ea2999078fecbd13cbe.tar.gz': None}
```

Unpack such dicts via a helper method.
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added the bug fix label Feb 5, 2025
@Micket Micket added this to the release after 4.9.4 milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants