-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use proxy in sanity check of custom easyblock to install OpenSSL wrapper #2922
use proxy in sanity check of custom easyblock to install OpenSSL wrapper #2922
Conversation
This reverts commit dbf2269. Syntax does not allow to have the value in the first line.
…s into use_https_proxy_in_sanity_check
Just updated the PR @akesandgren @jfgrimm ... apologies for the long delay. |
EB_OpenSSL_wrapper
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, also tested with OpenSSL/3
wrapper from easybuilders/easybuild-easyconfigs#19623
EB_OpenSSL_wrapper
One sanity check that tries to connect to github.com fails, when
OpenSSL-1.1.eb
is built on a machine without direct access to the internet.This PR resolves the issue by adding the parameter
-proxy
whenopenssl
is run. It only does so when the environment variablehttps_proxy
is defined.urlparse
fromurllib.parse
is used to determine the host and port of the proxy setting which could be a URL such ashttps://localproxy.cluster:4321/
.The change has been tested for environments with and without proxies, ie, direct access to the internet (environment variable
https_proxy
not set) and no direct access to the internet (environment variablehttps_proxy
set). See comments NorESSI/software-layer#100 (comment), NorESSI/software-layer#100 (comment) (both with direct access to internet) and NorESSI/software-layer#100 (comment) (no direct access to internet, original build failed, see NorESSI/software-layer#100 (comment)). The changed easyblock was used via--include-easyblocks=path/to/openssl_wrapper.py
.