Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use proxy in sanity check of custom easyblock to install OpenSSL wrapper #2922

Merged
merged 7 commits into from
Mar 6, 2024

Conversation

trz42
Copy link
Contributor

@trz42 trz42 commented Apr 23, 2023

One sanity check that tries to connect to github.com fails, when OpenSSL-1.1.eb is built on a machine without direct access to the internet.

This PR resolves the issue by adding the parameter -proxy when openssl is run. It only does so when the environment variable https_proxy is defined. urlparse from urllib.parse is used to determine the host and port of the proxy setting which could be a URL such as https://localproxy.cluster:4321/.

The change has been tested for environments with and without proxies, ie, direct access to the internet (environment variable https_proxy not set) and no direct access to the internet (environment variable https_proxy set). See comments NorESSI/software-layer#100 (comment), NorESSI/software-layer#100 (comment) (both with direct access to internet) and NorESSI/software-layer#100 (comment) (no direct access to internet, original build failed, see NorESSI/software-layer#100 (comment)). The changed easyblock was used via --include-easyblocks=path/to/openssl_wrapper.py.

@trz42
Copy link
Contributor Author

trz42 commented Feb 23, 2024

Just updated the PR @akesandgren @jfgrimm ... apologies for the long delay.

@boegel boegel changed the title use proxy in sanity check of EB_OpenSSL_wrapper use proxy in sanity check of EB_OpenSSL_wrapper Feb 28, 2024
@easybuilders easybuilders deleted a comment from boegelbot Feb 28, 2024
@boegel
Copy link
Member

boegel commented Mar 6, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenSSL-1.0.eb
  • SUCCESS OpenSSL-1.1.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3110.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/b32c5a59a4e2d4115dad1995a823acad for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also tested with OpenSSL/3 wrapper from easybuilders/easybuild-easyconfigs#19623

@boegel boegel merged commit d233b7f into easybuilders:develop Mar 6, 2024
47 checks passed
@boegel boegel changed the title use proxy in sanity check of EB_OpenSSL_wrapper use proxy in sanity check of custom easyblock to install OpenSSL wrapper Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants