-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply correct defaults for username / password #239
Conversation
8ad02ad
to
f1dd2ae
Compare
That's @DrRataplan for your contribution. I am just unsure what the best default is here:
|
I'm also unsure. I feel something for having leveled permissions: attempt using a Based on the comments in the file I touched and the README, Do we wanna go left or right? |
@DrRataplan I would like to update the readme with the actual defaults |
maybe together with #240 |
I am up for that, especially combined with the dotenv changes: I will then just make a dotenv in the folder that houses all my projects! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the readme to reflect the correct defaults instead.
f1dd2ae
to
9645cc5
Compare
@line-o Fixed that! |
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #213
Defaults were already documented at https://github.com/eXist-db/xst?tab=readme-ov-file#with-environment-variables