Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 46 and 55: volume recovery and its test case #58

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

yamingk
Copy link
Collaborator

@yamingk yamingk commented Mar 11, 2025

  1. Volume Index table recovery implementation.
  2. Add move constructor for VolumeInfo
  3. lookup_volume API implementation.
  4. Add volume create test case.
  5. Add restart functionality in the helper and found solo repl dev seems not supporting the recovery yet, slack: https://ebay-eng.slack.com/archives/C07JWRZGG4D/p1741823864031019

I will work on the solo repl dev recovery next.

@yamingk yamingk closed this Mar 11, 2025
@yamingk yamingk reopened this Mar 11, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 64.92537% with 47 lines in your changes missing coverage. Please review.

Project coverage is 45.23%. Comparing base (6d77f57) to head (9e9fc82).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/volume/volume.cpp 16.66% 19 Missing and 1 partial ⚠️
src/lib/volume/tests/test_common.hpp 70.37% 14 Missing and 2 partials ⚠️
src/lib/volume_mgr.cpp 18.18% 8 Missing and 1 partial ⚠️
src/lib/homeblks_impl.hpp 0.00% 1 Missing ⚠️
src/lib/volume/volume.hpp 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #58       +/-   ##
==========================================
+ Coverage   0.00%   45.23%   +45.23%     
==========================================
  Files          8       15        +7     
  Lines        172      409      +237     
  Branches      11       27       +16     
==========================================
+ Hits           0      185      +185     
- Misses       172      210       +38     
- Partials       0       14       +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume Create and volume Recovery Test Case. Recover Volumes on reboot
2 participants