Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing deprecated code from simple_plotly #2470

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

KS-HTK
Copy link
Collaborator

@KS-HTK KS-HTK commented Nov 29, 2024

This PR is the second part to #2469 . It removes the deprecated code and deprecation warnings
And it will be merged one release after the release containing #2469

This should be merged pandapower at any release after 3.1 but before 4.0.0

@KS-HTK KS-HTK marked this pull request as draft November 29, 2024 14:34
@KS-HTK KS-HTK changed the title [DRAFT] removing deprecated code from simple_plotly removing deprecated code from simple_plotly Nov 29, 2024
vogt31337
vogt31337 previously approved these changes Dec 13, 2024
@KS-HTK KS-HTK marked this pull request as ready for review March 7, 2025 08:41
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 26 lines in your changes missing coverage. Please review.

Project coverage is 75.45%. Comparing base (d453890) to head (e23f71c).

Files with missing lines Patch % Lines
pandapower/plotting/geo.py 0.00% 23 Missing ⚠️
pandapower/plotting/plotly/mapbox_plot.py 0.00% 1 Missing ⚠️
pandapower/plotting/plotly/pf_res_plotly.py 50.00% 1 Missing ⚠️
pandapower/plotting/plotly/vlevel_plotly.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2470      +/-   ##
===========================================
- Coverage    75.50%   75.45%   -0.05%     
===========================================
  Files          288      288              
  Lines        34905    34910       +5     
===========================================
- Hits         26354    26342      -12     
- Misses        8551     8568      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KS-HTK KS-HTK requested a review from vogt31337 March 11, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants