Skip to content

Create lines more general approach including 3ph params #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Create lines more general approach including 3ph params #1403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
816563a
Update create.py
elodin Nov 19, 2021
496ad47
create_lines() more general approach
elodin Nov 22, 2021
fce7396
update create_lines() with check_entry_in_std_type
elodin Nov 22, 2021
d4ae271
Merge branch 'develop' into create_lines_general_approach
elodin Nov 22, 2021
d33546b
Merge branch 'develop' into create_lines_general_approach
Dec 2, 2021
663f0ff
Merge branch 'develop' into create_lines_general_approach
Dec 2, 2021
f9ce0ca
Merge branch 'develop' into create_lines_general_approach
elodin Jun 8, 2022
319f2fe
remove uint32 as it is not used anymore
elodin Jun 8, 2022
0e0f286
Added changes in create_lines() to the changelog
elodin Jun 8, 2022
0a69173
correct changes entered to changelog
elodin Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Change Log
- [FIX] from_ppc() converter and power system test cases: add missing factor for tap_side=="lv"; change tap_side to "hv" for all test cases (were converted without new factor, so as the tap_side is "hv")
- [ADDED] from_mpc() converter: added functionality to import .m files via external package
- [CHANGED] from_ppc() converter: added option of tap_side and essential speed up
- [CHANGED] create_lines() now takes all parameters of the std_type into account, not just predefined ones

[2.9.0]- 2022-03-23
----------------------
Expand Down
44 changes: 24 additions & 20 deletions pandapower/create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1925,22 +1925,25 @@ def create_lines(net, from_buses, to_buses, length_km, std_type, name=None, inde
geodata=None, df=1., parallel=1, in_service=True, max_loading_percent=None, **kwargs):
""" Convenience function for creating many lines at once. Parameters 'from_buses' and 'to_buses'
must be arrays of equal length. Other parameters may be either arrays of the same length or
single or values. In any case the line parameters are defined through a single standard
single values. If std_type is an array with the same length, each new line will be assigned
the corresponding std_type.

Not valid anymore: In any case the line parameters are defined through a single standard
type, so all lines have the same standard type.


INPUT:
**net** - The net within this line should be created
**net** - The net within which this line should be created

**from_buses** (list of int) - ID of the bus on one side which the line will be \
**from_buses** (int or list of int) - ID of the bus on one side which the line will be \
connected with

**to_buses** (list of int) - ID of the bus on the other side which the line will be \
**to_buses** (int or list of int) - ID of the bus on the other side which the line will be \
connected with

**length_km** (list of float) - The line length in km

**std_type** (string) - The linetype of the lines.
**std_type** (string or list) - The linetype(s) of the lines.

OPTIONAL:
**name** (list of string, None) - A custom name for this line
Expand Down Expand Up @@ -1970,6 +1973,9 @@ def create_lines(net, from_buses, to_buses, length_km, std_type, name=None, inde
create_line(net, "line1", from_bus=0, to_bus=1, length_km=0.1, std_type="NAYY 4x50 SE")

"""
from_buses = [from_buses] if type(from_buses) == int else from_buses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User-friedlyness: even if the user only wants to create one line (as one is also a multiple of lines) and only passes the index as an int instead of a list, the function will work.

Also this could be a way to reduce the number of functions the user has to know by possibly replacing create_line().

What do you think about it?

to_buses = [to_buses] if type(to_buses) == int else to_buses

_check_multiple_branch_elements(net, from_buses, to_buses, "Lines")

index = _get_multiple_index_with_check(net, "line", index, len(from_buses))
Expand All @@ -1981,23 +1987,21 @@ def create_lines(net, from_buses, to_buses, length_km, std_type, name=None, inde
# add std type data
if isinstance(std_type, str):
lineparam = load_std_type(net, std_type, "line")
entries["r_ohm_per_km"] = lineparam["r_ohm_per_km"]
entries["x_ohm_per_km"] = lineparam["x_ohm_per_km"]
entries["c_nf_per_km"] = lineparam["c_nf_per_km"]
entries["max_i_ka"] = lineparam["max_i_ka"]
entries["g_us_per_km"] = lineparam["g_us_per_km"] if "g_us_per_km" in lineparam else 0.
if "type" in lineparam:
entries["type"] = lineparam["type"]
lineparam["g_us_per_km"] = lineparam["g_us_per_km"] if "g_us_per_km" in lineparam else 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not having this kind of logic here. If some types in pp std_type library are missing g_us_per_km, we should change it there (even if to 0).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should be responsible for providing the relevant parameters in std_type, I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. The user should be responsible. But the parameter should also be a natural part of the std_type, so the user knows what info needs to be provided in the first place.
Is the std_type going through a similar function as create_empty_network() during creation/loading of the net? Would make sense to add the parameter there, if it's missing.

entries.update(lineparam)
else:
lineparam = list(map(load_std_type, [net] * len(std_type), std_type, ['line'] * len(std_type)))
entries["r_ohm_per_km"] = list(map(itemgetter("r_ohm_per_km"), lineparam))
entries["x_ohm_per_km"] = list(map(itemgetter("x_ohm_per_km"), lineparam))
entries["c_nf_per_km"] = list(map(itemgetter("c_nf_per_km"), lineparam))
entries["max_i_ka"] = list(map(itemgetter("max_i_ka"), lineparam))
entries["g_us_per_km"] = list(map(check_entry_in_std_type, lineparam, ["g_us_per_km"] * len(lineparam),
[0.] * len(lineparam)))
entries["type"] = list(map(check_entry_in_std_type, lineparam, ["type"] * len(lineparam),
[None] * len(lineparam)))

# create comprehensive set of std_type params
# since 'g_us_per_km' needs to be specified for powerflow calc, but is often not part of std_type,
# it needs to be treated special here
params = set()
[params.add(list(lineparam[i].keys())[x]) for i in range(len(lineparam)) for x in range(len(lineparam[i].keys()))]
params.add('g_us_per_km')

for p in params:
else_val = [None] if p != 'g_us_per_km' else [0]
entries[p] = list(map(check_entry_in_std_type, lineparam, [p] * len(lineparam), else_val * len(lineparam)))

_add_series_to_entries(entries, index, "max_loading_percent", max_loading_percent)

Expand Down