Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR contains some API changes to enable threading. All in-place assignments to mutable structs have been removed/deprecated. All structs have been changed to immutable.
Using two threads gives the best performance on my PC (Ryzen 7 2700X, using
export JULIA_NUM_THREADS=2
). Time went down from 7 minutes to 5 minutes for the example in README.Assigning more threads will not further improve the performance, because now it is memory-bound. There are lots of memory assignments (about 700MB for each parameter combination). I suspect that is related to
TS
but have not looked into it.I know the API changes, especially getting rid of
!
operations, may not be ideal. So, feel free to accept, reject, or update this PR.