Skip to content

Feat/elf linker

Feat/elf linker #380

GitHub Actions / cpplint completed Jan 3, 2025 in 1s

reviewdog [cpplint] report

reported by reviewdog 🐶

Findings (19)

src/array.c|12| Include the directory when naming header files [build/include_subdir] [4]
src/array.h|11| #ifndef header guard has wrong style, please use: SRC_ARRAY_H_ [build/header_guard] [5]
src/array.h|101| #endif line should be "#endif // SRC_ARRAY_H_" [build/header_guard] [5]
src/cjit.c|42| Lines should be <= 120 characters long [whitespace/line_length] [2]
src/cjit.c|61| If you can, use sizeof(dirname) instead of 63 as the 2nd arg to snprintf. [runtime/printf] [3]
src/cjit.c|195| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
src/cjit.c|270| Missing space after ; [whitespace/semicolon] [3]
src/cjit.c|276| Missing space after ; [whitespace/semicolon] [3]
src/cjit.c|284| Missing space after ; [whitespace/semicolon] [3]
src/elflinker.c|59| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
src/elflinker.c|332| Add #include for snprintf [build/include_what_you_use] [4]
src/elflinker.h|1| #ifndef header guard has wrong style, please use: SRC_ELFLINKER_H_ [build/header_guard] [5]
src/elflinker.h|18| #endif line should be "#endif // SRC_ELFLINKER_H_" [build/header_guard] [5]
src/file.c|115| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/file.c|125| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/file.c|128| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/file.c|137| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/file.c|140| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/file.c|145| Almost always, snprintf is better than strcpy [runtime/printf] [4]

Filtered Findings (0)

Annotations

Check warning on line 12 in src/array.c

@github-actions github-actions / cpplint

[cpplint] src/array.c#L12

 Include the directory when naming header files  [build/include_subdir] [4]
Raw output
src/array.c:12:  Include the directory when naming header files  [build/include_subdir] [4]

Check warning on line 11 in src/array.h

@github-actions github-actions / cpplint

[cpplint] src/array.h#L11

 #ifndef header guard has wrong style, please use: SRC_ARRAY_H_  [build/header_guard] [5]
Raw output
src/array.h:11:  #ifndef header guard has wrong style, please use: SRC_ARRAY_H_  [build/header_guard] [5]

Check warning on line 101 in src/array.h

@github-actions github-actions / cpplint

[cpplint] src/array.h#L101

 #endif line should be "#endif  // SRC_ARRAY_H_"  [build/header_guard] [5]
Raw output
src/array.h:101:  #endif line should be "#endif  // SRC_ARRAY_H_"  [build/header_guard] [5]

Check warning on line 42 in src/cjit.c

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L42

 Lines should be <= 120 characters long  [whitespace/line_length] [2]
Raw output
src/cjit.c:42:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 61 in src/cjit.c

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L61

 If you can, use sizeof(dirname) instead of 63 as the 2nd arg to snprintf.  [runtime/printf] [3]
Raw output
src/cjit.c:61:  If you can, use sizeof(dirname) instead of 63 as the 2nd arg to snprintf.  [runtime/printf] [3]

Check warning on line 195 in src/cjit.c

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L195

 Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
Raw output
src/cjit.c:195:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]

Check warning on line 270 in src/cjit.c

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L270

 Missing space after ;  [whitespace/semicolon] [3]
Raw output
src/cjit.c:270:  Missing space after ;  [whitespace/semicolon] [3]

Check warning on line 276 in src/cjit.c

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L276

 Missing space after ;  [whitespace/semicolon] [3]
Raw output
src/cjit.c:276:  Missing space after ;  [whitespace/semicolon] [3]

Check warning on line 284 in src/cjit.c

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L284

 Missing space after ;  [whitespace/semicolon] [3]
Raw output
src/cjit.c:284:  Missing space after ;  [whitespace/semicolon] [3]

Check warning on line 59 in src/elflinker.c

@github-actions github-actions / cpplint

[cpplint] src/elflinker.c#L59

 Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
Raw output
src/elflinker.c:59:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]

Check warning on line 332 in src/elflinker.c

@github-actions github-actions / cpplint

[cpplint] src/elflinker.c#L332

 Add #include <cstdio> for snprintf  [build/include_what_you_use] [4]
Raw output
src/elflinker.c:332:  Add #include <cstdio> for snprintf  [build/include_what_you_use] [4]

Check warning on line 1 in src/elflinker.h

@github-actions github-actions / cpplint

[cpplint] src/elflinker.h#L1

 #ifndef header guard has wrong style, please use: SRC_ELFLINKER_H_  [build/header_guard] [5]
Raw output
src/elflinker.h:1:  #ifndef header guard has wrong style, please use: SRC_ELFLINKER_H_  [build/header_guard] [5]

Check warning on line 18 in src/elflinker.h

@github-actions github-actions / cpplint

[cpplint] src/elflinker.h#L18

 #endif line should be "#endif  // SRC_ELFLINKER_H_"  [build/header_guard] [5]
Raw output
src/elflinker.h:18:  #endif line should be "#endif  // SRC_ELFLINKER_H_"  [build/header_guard] [5]

Check warning on line 115 in src/file.c

@github-actions github-actions / cpplint

[cpplint] src/file.c#L115

 Almost always, snprintf is better than strcpy  [runtime/printf] [4]
Raw output
src/file.c:115:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]

Check warning on line 125 in src/file.c

@github-actions github-actions / cpplint

[cpplint] src/file.c#L125

 Almost always, snprintf is better than strcpy  [runtime/printf] [4]
Raw output
src/file.c:125:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]

Check warning on line 128 in src/file.c

@github-actions github-actions / cpplint

[cpplint] src/file.c#L128

 Almost always, snprintf is better than strcpy  [runtime/printf] [4]
Raw output
src/file.c:128:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]

Check warning on line 137 in src/file.c

@github-actions github-actions / cpplint

[cpplint] src/file.c#L137

 Almost always, snprintf is better than strcpy  [runtime/printf] [4]
Raw output
src/file.c:137:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]

Check warning on line 140 in src/file.c

@github-actions github-actions / cpplint

[cpplint] src/file.c#L140

 Almost always, snprintf is better than strcpy  [runtime/printf] [4]
Raw output
src/file.c:140:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]

Check warning on line 145 in src/file.c

@github-actions github-actions / cpplint

[cpplint] src/file.c#L145

 Almost always, snprintf is better than strcpy  [runtime/printf] [4]
Raw output
src/file.c:145:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]