Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor core CJIT code #90

Merged
merged 8 commits into from
Dec 26, 2024

fix: more build refactoring

1bdcf22
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix: refactor core CJIT code #90

fix: more build refactoring
1bdcf22
Select commit
Loading
Failed to load commit list.
GitHub Actions / cpplint completed Dec 26, 2024 in 1s

reviewdog [cpplint] report

reported by reviewdog 🐶

Findings (12)

src/cjit.c|51| If you can, use sizeof(filename) instead of 63 as the 2nd arg to snprintf. [runtime/printf] [3]
src/cjit.c|79| If you can, use sizeof(tempDir) instead of 259 as the 2nd arg to snprintf. [runtime/printf] [3]
src/cjit.c|95| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/cjit.c|154| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
src/cjit.c|185| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/cjit.c|186| Almost always, snprintf is better than strcat [runtime/printf] [4]
src/cjit.c|193| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/cjit.c|195| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/cjit.c|307| Add #include for vsnprintf [build/include_what_you_use] [4]
src/main.c|151| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/main.c|156| Almost always, snprintf is better than strcpy [runtime/printf] [4]
src/main.c|170| Add #include for fprintf [build/include_what_you_use] [4]

Filtered Findings (0)

Annotations

Check warning on line 51 in src/cjit.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L51

 If you can, use sizeof(filename) instead of 63 as the 2nd arg to snprintf.  [runtime/printf] [3]
Raw output
src/cjit.c:51:  If you can, use sizeof(filename) instead of 63 as the 2nd arg to snprintf.  [runtime/printf] [3]

Check warning on line 79 in src/cjit.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L79

 If you can, use sizeof(tempDir) instead of 259 as the 2nd arg to snprintf.  [runtime/printf] [3]
Raw output
src/cjit.c:79:  If you can, use sizeof(tempDir) instead of 259 as the 2nd arg to snprintf.  [runtime/printf] [3]

Check warning on line 95 in src/cjit.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L95

 Almost always, snprintf is better than strcpy  [runtime/printf] [4]
Raw output
src/cjit.c:95:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]

Check warning on line 154 in src/cjit.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L154

 Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
Raw output
src/cjit.c:154:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]

Check warning on line 185 in src/cjit.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L185

 Almost always, snprintf is better than strcpy  [runtime/printf] [4]
Raw output
src/cjit.c:185:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]

Check warning on line 186 in src/cjit.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L186

 Almost always, snprintf is better than strcat  [runtime/printf] [4]
Raw output
src/cjit.c:186:  Almost always, snprintf is better than strcat  [runtime/printf] [4]

Check warning on line 193 in src/cjit.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L193

 Almost always, snprintf is better than strcpy  [runtime/printf] [4]
Raw output
src/cjit.c:193:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]

Check warning on line 195 in src/cjit.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L195

 Almost always, snprintf is better than strcpy  [runtime/printf] [4]
Raw output
src/cjit.c:195:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]

Check warning on line 307 in src/cjit.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/cjit.c#L307

 Add #include <cstdio> for vsnprintf  [build/include_what_you_use] [4]
Raw output
src/cjit.c:307:  Add #include <cstdio> for vsnprintf  [build/include_what_you_use] [4]

Check warning on line 151 in src/main.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/main.c#L151

 Almost always, snprintf is better than strcpy  [runtime/printf] [4]
Raw output
src/main.c:151:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]

Check warning on line 156 in src/main.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/main.c#L156

 Almost always, snprintf is better than strcpy  [runtime/printf] [4]
Raw output
src/main.c:156:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]

Check warning on line 170 in src/main.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/main.c#L170

 Add #include <cstdio> for fprintf  [build/include_what_you_use] [4]
Raw output
src/main.c:170:  Add #include <cstdio> for fprintf  [build/include_what_you_use] [4]