Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3270 Use vectors instead of old pointers. #3271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#3270 Use vectors instead of old pointers. #3271

wants to merge 1 commit into from

Conversation

gautierbureau
Copy link
Member

Checklist before requesting a review

use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes

  • unit tests and non-regression tests were added (new model, new feature and bug fix)
  • main documentation was updated (update of input/output file, 3rd party, model, repository organization, solver)
  • example documentations were updated (new example in examples folder)
  • the corresponding milestone was added in the ticket and in this PR
  • if this PR modifies the parameters or inputs/outputs of a model/solver: the corresponding xsl was added in util/xsl and platform DB were updated
  • if this PR modifies a dictionary: the corresponding french dictionary was updated

@gautierbureau gautierbureau linked an issue Jun 10, 2024 that may be closed by this pull request
Use std::vector instead of old pointers #3270
Open
@gautierbureau gautierbureau added this to the v1.7.0 milestone Jun 10, 2024
rosiereflo
rosiereflo requested changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@rosiereflo rosiereflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the nrts passing? (public and private) thanks

dynawo/sources/Modeler/Common/DYNModelMulti.cpp Outdated
connectorContainer_->propagateZConnectionInfoToModel();
std::fill(fLocal_ + offsetFOptional_, fLocal_ + sizeF_, 0);
std::fill(fLocal_.begin(), fLocal_.end(), 0.);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not equivalent to the existing line

@gautierbureau gautierbureau force-pushed the 3270_vector_instead_of_pointers branch from a8ca2e0 to 1f8f6cf Compare June 20, 2024 08:06
@gautierbureau gautierbureau changed the title #3270 Use vectors instead of all pointers. #3270 Use vectors instead of old pointers. Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosiereflo rosiereflo rosiereflo requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Code quality
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Use std::vector instead of old pointers
2 participants
@gautierbureau @rosiereflo