feat: forced result tool #7
Conversation
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
| const content = newMessage.content as ContentBlockParam[] | ||
| content.push(await this.call(submessage)) |
There was a problem hiding this comment.
1️⃣ If I follow correctly, we moved the normalization of the tool call info from here...
| submessageIdx: nextSubmessage, | ||
| toolCallId: submessage.id | ||
| } | ||
| } |
| const { tool, submessageIdx, toolCallIndex, toolCallLength, toolCallId } = | ||
| this.parseNextToolCall(stage) | ||
|
|
||
| content.push(await this.call(tool, toolCallId!)) |
There was a problem hiding this comment.
3️⃣ so we can pass it directly here. But I don't see any other changes to the logic?
| @@ -169,11 +172,16 @@ export class Driver { | |||
| const { response, messages, index, status, toolCallIndex } = stage | |||
| switch (status) { | |||
| case 'pending': { | |||
| const tools = config.tools?.map(mcpxToolToAnthropic) || this.#tools | |||
There was a problem hiding this comment.
4️⃣ this would be the load-bearing change, right? (Assuming users could already pass tool_choice as a part of config?)
There was a problem hiding this comment.
that's right. I don't love the fact that we are abusing the anthropic-specific config to pass a foreign config key. We could expose a separate "mcpToolConfig" object for this specific purpose though
| @@ -38,6 +38,16 @@ export interface McpxAnthropicStage { | |||
| } | |||
|
|
|||
|
|
|||
| function anthropicToolCallToMcpxToolCall(submessage: any): any { | |||
There was a problem hiding this comment.
oooh, I see – this is a normalization pass to unify the return type with mcpx-openai.
There was a problem hiding this comment.
yeah, technically to align it to the MCP CallToolRequest definition
it depends if we want to keep the tool conversion logic isolated here, or we want to duplicate it into mcp.run/api |
allow passing an optional
configtonext(). The allowed keys are the anthropic config keys, plus:tools: Tool[](an MCP tool def)tool_choice?: string, if present, the name of exactly one tool in the tool list (either the one provided, or the one returned by the session)