Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add answer for auth/issues/169 #92

Merged
merged 9 commits into from
Jan 28, 2022

Conversation

nelsonic
Copy link
Member

busy writing up answer to this question: dwyl/auth#169

@nelsonic nelsonic self-assigned this Dec 27, 2021
@nelsonic nelsonic changed the title add answer for https://github.com/dwyl/auth/issues/169 add answer for auth/issues/169 Dec 28, 2021
@nelsonic nelsonic assigned SimonLab and unassigned nelsonic Jan 26, 2022
@nelsonic nelsonic requested a review from SimonLab January 26, 2022 10:56
@nelsonic
Copy link
Member Author

Hi @SimonLab 👋 Hope your morning is going well so far! ☀️
It occurred to me that this PR is in a reviewable state but I forgot to assign it. 🤦‍♂️
If you don't mind reading it over and sense checking it, please do. (and merge if OK).
Thanks!

Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typo fixes suggestions, otherwise looks good

@SimonLab SimonLab assigned nelsonic and unassigned SimonLab Jan 28, 2022
@nelsonic
Copy link
Member Author

All your suggestions applied. Thanks @SimonLab 👍

Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimonLab SimonLab merged commit b7e593e into main Jan 28, 2022
@SimonLab SimonLab deleted the clarify-fields-emailhash-and-emailencrypted-issue-#169 branch January 28, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants