Check for table's name uniquess in core instead of fetching all tables in front when upserting #11600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in front when upserting
|
spolu
approved these changes
Mar 25, 2025
Fraggle
added
the
documentation-ack
It's not and I don't know why, especially since @fontanierh mention that it has to be unique in the table schema. |
|
Let's add an index for that no? Not necessarily unique to avoid any issue. I'm more concerned by perf? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we upsert a table we were fetching all the tables to check for uniqueness of datasource & name which is computationnaly intensive.
This PR move the check to core in a much more efficient way.
Tests
Local
Risk
Low, very low usage of this endpoint outside of controlled
connectorscode.Deploy Plan
Deploy
core&front