Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frank/structured outputs #11589

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Frank/structured outputs #11589

merged 3 commits into from
Mar 25, 2025

Conversation

frankaloia
Copy link
Contributor

Description

  • Adding support for openai models that allow response formatting
  • Not directly handling the "refusal" field as an error. Allowing customers to determine how they will handle that as it is included in the chat output.
  • In the conversation, detecting if an app output is valid json. if so, including it as a document attached to the conversation. This allows customers to view the raw structured output if they desire.

Tests

Screenshot 2025-03-25 at 10 42 02 AM Screenshot 2025-03-25 at 11 18 14 AM Screenshot 2025-03-25 at 11 18 18 AM Screenshot 2025-03-25 at 11 18 37 AM

Risk

Able to rollback

Deploy Plan

Deploy via github

@frankaloia frankaloia requested a review from flvndvd March 25, 2025 15:29
flvndvd
flvndvd approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@flvndvd flvndvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Propre \o/!

front/components/app/blocks/Chat.tsx
const parsed = responseFormat.trim()
? JSON.parse(responseFormat)
: undefined;
parsed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit
For this type of condition, ternary makes the code slightly more complex to read.

front/lib/actions/dust_app_run.ts
content: JSON.stringify(parsed, null, 2),
},
};
} catch {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we log?

@frankaloia frankaloia merged commit 8dd2e67 into main Mar 25, 2025
6 checks passed
@frankaloia frankaloia deleted the frank/structured-outputs branch March 25, 2025 16:58
@frankaloia frankaloia mentioned this pull request Mar 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flvndvd flvndvd flvndvd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankaloia @flvndvd