Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upg: use proxy for oauth #11540

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Upg: use proxy for oauth #11540

merged 1 commit into from
Mar 21, 2025

Conversation

Fraggle
Copy link
Contributor

@Fraggle Fraggle commented Mar 21, 2025

Description

Use proxy if env var provided for oauth so our customers can whitelist a fixed ip.

Tests

Green

Risk

Low, will fallback to no proxy if some issue, can be reverted.

Deploy Plan

deploy & add env vars to oauth pods.

@Fraggle Fraggle requested review from spolu and flvndvd March 21, 2025 16:54
Copy link
Contributor

@flvndvd flvndvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to add those variables?

@Fraggle
Copy link
Contributor Author

Fraggle commented Mar 21, 2025

@flvndvd yep, they are not provided there as of today.

Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Fraggle Fraggle merged commit ecf6b64 into main Mar 21, 2025
6 checks passed
@Fraggle Fraggle deleted the sflory-use-proxy-for-oauth branch March 21, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants